Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests for some 32-bit types that already work in metrics #215

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add missing tests for some 32-bit types that already work in metrics #215

merged 2 commits into from
Jul 17, 2024

Conversation

navaati
Copy link
Contributor

@navaati navaati commented Jul 17, 2024 •
edited
Loading

This adds tests for the new capabilities enabled by #173.

@navaati
Copy link
Contributor Author

navaati commented Jul 17, 2024 •
edited
Loading

f32 and i32 don’t work yet due to missing Atomic implementation. See #216.

@navaati navaati changed the title Add missing tests for 32-bit types in metrics Add missing test for u32 in Counter Jul 17, 2024
@navaati navaati marked this pull request as ready for review July 17, 2024 17:26
@navaati navaati changed the title Add missing test for u32 in Counter Add missing tests for some 32-bit types that already work in metrics Jul 17, 2024
@navaati
test(portability): Test i32 for Gauge
fbb148b 
Signed-off-by: Léo Gillot-Lamure <[email protected]>
@navaati
Copy link
Contributor Author

navaati commented Jul 17, 2024

I don’t think changelog edit is required for just adding tests.

@navaati
Copy link
Contributor Author

navaati commented Jul 17, 2024

@mxinden small easy PR, pls review !

mxinden
mxinden approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks! More tests is always appreciated.

@mxinden mxinden merged commit 4216fa6 into prometheus:master Jul 17, 2024
10 checks passed
@navaati navaati deleted the tests_32bit branch July 17, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navaati @mxinden