Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irregular syntax in content type #865

Open
TomTriple opened this issue Sep 20, 2023 · 1 comment
Open

irregular syntax in content type #865

TomTriple opened this issue Sep 20, 2023 · 1 comment

Comments

@TomTriple
Copy link

TomTriple commented Sep 20, 2023

In

public final static String CONTENT_TYPE_OPENMETRICS_100 = "application/openmetrics-text; version=1.0.0; charset=utf-8";
you specified parameter version=1.0.0 which is not valid syntax according to https://www.w3.org/Protocols/rfc1341/4_Content-Type.html (it is not allowed to use . in an unquoted parameter value).

Please see also discussion here zio/zio-http#2416 (comment).

Valid syntax in this case should be version="1.0.0".

@fstab
Copy link
Member

fstab commented Sep 20, 2023

Thanks a lot! This is interesting: The content type String is literally copied out of the OpenMetrics spec:

The content type MUST be: application/openmetrics-text; version=1.0.0; charset=utf-8

Could you open an issue in the https://github.com/OpenObservability/OpenMetrics repo? I'm curious what they think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants