Merge pull request #856 from dhoard/text-write-performance-change

Changed to remove use of inefficient String method
prometheus · Aug 5, 2023 · a76a65d · a76a65d
2 parents 98967b8 + 27fe3b7
commit a76a65d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.java b/simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.java
@@ -137,8 +137,9 @@ public static void write004(Writer writer, Enumeration<Collector.MetricFamilySam
   }
 
   private static void writeEscapedHelp(Writer writer, String s) throws IOException {
-    for (int i = 0; i < s.length(); i++) {
-      char c = s.charAt(i);
+    char[] characters = s.toCharArray();
+    for (int i = 0; i < characters.length; i++) {
+      char c = characters[i];
       switch (c) {
         case '\\':
           writer.append("\\\\");
@@ -153,8 +154,9 @@ private static void writeEscapedHelp(Writer writer, String s) throws IOException
   }
 
   private static void writeEscapedLabelValue(Writer writer, String s) throws IOException {
-    for (int i = 0; i < s.length(); i++) {
-      char c = s.charAt(i);
+    char[] characters = s.toCharArray();
+    for (int i = 0; i < characters.length; i++) {
+      char c = characters[i];
       switch (c) {
         case '\\':
           writer.append("\\\\");