Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to hostprocess base image and add support for Windows Server 2025 on Kubernetes (click PR number for more information) #1731

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Nov 13, 2024

Standard Windows Containers always require a extact version match between Container OS and Host OS. This requires multiple images flavors, e.g. one for Windows Server 2019 and one for Windows Server 2022. With Windows Server 2025 release, we have now the 3rd flavor which needs to be supported.

However, this constraint may not exists, if a Windows container runs as a hostprocess. Running as hostprocess is nessesary for windows_exporter to gain all necessary information. A dedicate image for each Windows OS isn't technically nessary.

For this use-case, Microsoft create a scratch like Docker Images, which is designed for that use-case:
https://github.com/microsoft/windows-host-process-containers-base-image

It's has no contraints against the host OS and the image size is reduced to few MBs. However, it must be build in a buildkit environment on a Linux system.

The noticeable breaking change is that the official docker image not longer support to run a non-hostprocess container.

@jkroepke jkroepke requested a review from a team as a code owner November 13, 2024 23:07
@jkroepke jkroepke changed the base branch from hostprocess to master November 13, 2024 23:08
@jkroepke jkroepke force-pushed the hostprocess branch 2 times, most recently from 797789c to 4f8de5e Compare November 13, 2024 23:12
@jkroepke jkroepke changed the title chore: Switch to hostprocess base image chore: Switch to hostprocess base image (click PR number for more information) Nov 13, 2024
@jkroepke jkroepke changed the title chore: Switch to hostprocess base image (click PR number for more information) chore: Switch to hostprocess base image and add support for Windows Server 2025 on Kubernetes (click PR number for more information) Nov 13, 2024
@jkroepke jkroepke merged commit d13d726 into prometheus-community:master Nov 14, 2024
6 checks passed
@jkroepke jkroepke deleted the hostprocess branch November 14, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant