Add revision history limit value to all deployments #5228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarstenSon
requested review from
cristiangreco,
thomaspeitz,
rpahli,
wilfriedroset,
walker-tom,
xiu,
acondrat,
zanhsieh,
desaintmartin,
Juanchimienti,
monotek,
cstaud,
gianrubio,
zeritti,
dongjiang1989,
stewartshea,
nlamirault,
caarlos0,
okgolove,
steven-sheehy,
rsicart,
gkarthiks,
golgoth31,
schmiddim,
arslanbekov,
timm088,
asherf,
torstenwalter and
rsotnychenko
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds a configurable value of revisionHistoryLimit to all deployments across all prometheus helm charts and initializes them at the default value of 10.
This will enable users of this helm chart to easily decrease the number of retained replicaSets per deployment to fit into smaller clusters or environments or just to get a better overview.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])