Skip to content

Commit

Permalink
fail pipeline, if helm push is not successful (#3506)
Browse files Browse the repository at this point in the history
Signed-off-by: Jan-Otto Kröpke <[email protected]>
  • Loading branch information
jkroepke authored Jun 19, 2023
1 parent e9c3665 commit abc3d5f
Showing 1 changed file with 1 addition and 24 deletions.
25 changes: 1 addition & 24 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,28 +56,5 @@ jobs:
if [ -z "${pkg:-}" ]; then
break
fi
if ! helm push "${pkg}" "oci://ghcr.io/${GITHUB_REPOSITORY_OWNER}/charts"; then
echo '::warning:: helm push failed!'
fi
helm push "${pkg}" "oci://ghcr.io/${GITHUB_REPOSITORY_OWNER}/charts"
done
# - uses: sigstore/[email protected]
# - name: Push charts to GHCR and sign
# env:
# COSIGN_EXPERIMENTAL: 1
# # when filling gaps with previously released charts, cr would create
# # nothing in .cr-release-packages/, and the original globbing character
# # would be preserved, causing a non-zero exit. Set nullglob to fix this
# run: |
# shopt -s nullglob
# for pkg in .cr-release-packages/*; do
# if [ -z "${pkg:-}" ]; then
# break
# fi
# helm push "${pkg}" oci://ghcr.io/"${GITHUB_REPOSITORY_OWNER}"/charts > .digest
# file=${pkg##*/} # extracts file name from full directory path
# name=${file%-*} # extracts chart name from filename
# digest=$(awk -F "[, ]+" '/Digest/{print $NF}' < .digest)
# cosign sign ghcr.io/"${GITHUB_REPOSITORY_OWNER}"/charts/"${name}"@"${digest}"
# done

0 comments on commit abc3d5f

Please sign in to comment.