Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.1.5 #221

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Release 4.1.5 #221

merged 5 commits into from
Oct 24, 2024

Conversation

RohitKandimalla
Copy link
Contributor

@RohitKandimalla RohitKandimalla commented Oct 10, 2024

Pull requests into cqm-models require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

In order to tackle all instances of Date Field to adhere to previous changes from #219 and have a new constructor name other than just Date, we have to update the baseTypes.Any which accepts Date as a valid Choice Type, and it has to be CqlDate instead of cql.DateTime as there is a conflict with constructor name of Mongoose Date vs Cql-Execution Date Class.

Ticket: https://jira.cms.gov/browse/MAT-7774

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass
  • If applicable, the library version number in package.json and cqm-models.gemspec has been updated
  • Cqm-execution fixtures have been updated with the update_cqm_execution_fixtures.sh script inside server-scripts using this branch in the cqm-converter

Bonnie Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Cypress Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@RohitKandimalla RohitKandimalla changed the title Mat 6370 adding custom date class v2 Release v4.1.5 Oct 10, 2024
@RohitKandimalla RohitKandimalla self-assigned this Oct 10, 2024
jkotanchik-SB
jkotanchik-SB previously approved these changes Oct 15, 2024
adongare
adongare previously approved these changes Oct 21, 2024
Copy link
Contributor

@adongare adongare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RohitKandimalla RohitKandimalla changed the title Release v4.1.5 Release 4.1.5 Oct 21, 2024
@RohitKandimalla RohitKandimalla merged commit 6e09871 into master Oct 24, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants