Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 264: Migrating changes from fqm-execution related to LocalId i… #265

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

gregory-akins
Copy link
Collaborator

…ssues which stemmed from BONNIEMAT 1850 ticket & associated CQFramework changes

Pull requests into cqm-execution require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@dczulada
Copy link
Contributor

@gregory-akins Will this likely be tagged as a 4.2.0 version.

@dczulada dczulada self-requested a review July 16, 2024 13:22
dczulada
dczulada previously approved these changes Jul 16, 2024
@gregory-akins
Copy link
Collaborator Author

@gregory-akins Will this likely be tagged as a 4.2.0 version.

I think that will be up to Mitre

@gregory-akins gregory-akins merged commit 4a79acf into master Jul 16, 2024
3 of 4 checks passed
@gregory-akins gregory-akins deleted the Issue264-LocalIdFix branch July 16, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants