Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using index to differentiate between reused observation definitions f… #261

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

RohitKandimalla
Copy link
Contributor

…or multiple groups

Pull requests into cqm-execution require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

https://jira.cms.gov/browse/MAT-6782
Contents from reported bug
image

Scenario:
When a same function definition is used as an observation in more than 1 group, Observation results are not captured for the 1st group.
This is due to overwriting of existing object while generating ELM JSON.
This PR is to make sure every observation definition that is in a measure has its own unique observationDef name i.e by marking it with an index.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@RohitKandimalla RohitKandimalla merged commit 080c510 into master Mar 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants