Date query builder uses name instead of xpath #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some
_typeFilter
functionality that we had slightly incorrect for mostly date search parameters. Now we can use the correct search parameters such asEncounter.onset-date
.New behavior
We now properly map search parameters to their xpath so that fhir-qb can properly build a search query. Before, the user could only use _typeFilter queries with the xpath, such as
Encounter.onsetDateTime
, when the correct search isEncounter.onset-date
. This was simply a matter of making sure the parameterDefinitions had the correct keys when being passed intobuildSearchQuery
.Code changes
src/util/exportToNDJson.js
- make sure the search param keys are the nametest/util/exportToNDJson.js
- change unit tests to have proper _typeFilter search parametersTesting guidance
npm run check
npm run start
Encounter.date
) will still not work as expected. This still needs to be addressed in our fork ofnode-fhir-server-core
and there is a task for that in the BL!