Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexporter mapping for 130 and initial README #50

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

lmd59
Copy link
Contributor

@lmd59 lmd59 commented Aug 16, 2024

Summary

Adds initial flexporter mapping for qicore which addresses specific data elements required for CMS130. Also adds README explaining initial flexporter mapping process and recommendations for the future.
Note: Recommended future tasking could involve creating a script to pull synthea in here and run flexporter mappings for bulk data generation. Some scripting could also be created to streamline the mapping creation process.

New behavior

Synthea run with flexporter mapping creates data that is conformant enough to qicore for the purposes of CMS130 calculation.

Code changes

Creates flexporter mapping files and README file.

Testing guidance

Read through the README, run the synthea flexporter with something like ./run_synthea -fm qicore_130.yaml. Look at the output patient file and confirm that the appropriate resources and fields are exported. You can create additional patients with the -p {populationSize} option. You can run resulting patients through fqm-execution calculations with CMS130 and make sure they calculate appropriately.

Copy link

github-actions bot commented Aug 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.63% 574/759
🟡 Branches 63.19% 206/326
🟡 Functions 75.83% 91/120
🟡 Lines 75.87% 566/746

Test suite run success

95 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 8c41dcc

@elsaperelli elsaperelli self-requested a review August 19, 2024 13:18
@elsaperelli elsaperelli self-assigned this Aug 19, 2024
Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason running with this mapping causes the output to not have the id fields on many of the resources. This causes issues when running with fqm-execution as the ids are necessary for proper execution.

@lmd59
Copy link
Contributor Author

lmd59 commented Sep 3, 2024

For some reason running with this mapping causes the output to not have the id fields on many of the resources. This causes issues when running with fqm-execution as the ids are necessary for proper execution.

This is a bug in flexporter, which is fixed by this PR: synthetichealth/synthea#1501.

Copy link
Collaborator

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be misunderstanding the purpose of must supports, but there were some must supports that were not present on the generated patient's resources.

Other than that, just some small feedback!

synthea/README.md Outdated Show resolved Hide resolved
synthea/README.md Outdated Show resolved Hide resolved
synthea/README.md Outdated Show resolved Hide resolved
synthea/README.md Outdated Show resolved Hide resolved
synthea/README.md Outdated Show resolved Hide resolved
synthea/README.md Show resolved Hide resolved
synthea/README.md Show resolved Hide resolved
synthea/README.md Outdated Show resolved Hide resolved
synthea/README.md Show resolved Hide resolved
synthea/README.md Show resolved Hide resolved
synthea/README.md Show resolved Hide resolved
synthea/README.md Show resolved Hide resolved
Copy link
Collaborator

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank so much for answering all my questions! Really helped me get a better understanding of this :)

With that said, LGTM!

@hossenlopp hossenlopp merged commit 178dc1a into main Sep 5, 2024
4 checks passed
@hossenlopp hossenlopp deleted the flexporter-130 branch September 5, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants