Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Typo and remove unnecessary parameter

Co-authored-by: Elsa Perelli <[email protected]>
  • Loading branch information
lmd59 and elsaperelli authored Jul 31, 2024
1 parent fa6c8b1 commit 5bba357
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/services/export.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const bulkExport = async (request, reply) => {
}
if (validateExportParams(parameters, reply)) {
request.log.info('Base >>> $export');
const clientEntry = await addPendingBulkExportRequest(parameters._bySubject === 'Patient');
const clientEntry = await addPendingBulkExportRequest();

const types = request.query._type?.split(',') || parameters._type?.split(','); //TODO, does gatherParams not pull from the query as well? Why is this OR required?

Expand Down
2 changes: 1 addition & 1 deletion src/util/mongo.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const findResourcesWithAggregation = async (query, resourceType, options = {}) =
/**
* Called as a result of export request. Adds a new clientId to db
* which can be queried to get updates on the status of the bulk export
* @param {boolean} byPatient indicated whether this export request groups data by patient (versus by type)
* @param {boolean} byPatient indicates whether this export request groups data by patient (versus by type)
* @returns the id of the inserted client
*/
const addPendingBulkExportRequest = async (byPatient = false) => {
Expand Down

0 comments on commit 5bba357

Please sign in to comment.