Status.Ready #210
Merged
Status.Ready #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status.Ready will be set to true first time sveltoscluster controller
can reach the managed cluster.
Once set to true, `Status.Ready` will never be set to false again.
If an error occurs connecting to the managed cluster, the error will
be reported in the `Status.FailureMessage` field and `Status.Ready` will
continue to stay set to true.
For instance
```
status:
failureMessage: 'failed to get API group resources: unable to retrieve the complete
list of server APIs: v1: Get "https://212.2.243.209:6443/api/v1": dial tcp 212.2.243.209:6443:
i/o timeout'
ready: true
version: v1.29.2+k3s1
```
This means Ready indicates that at least once the cluster was reachable.
Before this PR a temporary network connectivity issue had bad effect:
1. Sveltoscluster controller could not temporarily reach the managed cluster =>
set Status.Ready to false
2. Sveltos addon-controller reacted a Ready=false cluster by considering it
a non match => all clusterSummaries corresponding to such a cluster deleted
3. A deleted ClusterSummary removes all deployed add-ons and applications from
the cluster
With this PR, above does not happen anymore.
A temporary network connectivity issue simply causes SveltoCluster controller
to set `FailureMessage`. No more point 2 and 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status.Ready will be set to true first time sveltoscluster controller can reach the managed cluster.
Once set to true,
Status.Readywill never be set to false again.If an error occurs connecting to the managed cluster, the error will be reported in the
Status.FailureMessagefield andStatus.Readywill continue to stay set to true.For instance
This means Ready indicates that at least once the cluster was reachable.
Before this PR a temporary network connectivity issue had bad effect:
With this PR, above does not happen anymore.
A temporary network connectivity issue simply causes SveltoCluster controller to set
FailureMessage. No more point 2 and 3.Closes #209