(feat) add patches to ResourceSummary #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianlucam76
force-pushed
the
ignore-drift
branch
from
fa87f05 to
4e3e74a
Compare
When creating Profile/ClusterProfile with syncMode set to `ContinuousWithDriftDetection` user will have the ability to specify set of paths for certain resources that need to be ignored during configuration drift evaluation. User can use the field `DriftExclusions`. This is helpful for instance when a Deployment is deployed by Sveltos along an autoscaler. Autoscaler will scale `replicas` up and down. So we don't want a replicas change to be seen as a configuration drift. addon-manager will pass resources that need to be watched for configuration drift and will transform DriftExclusions into a slices of `Patch`. Operation is always set to remove as the goal of a DriftExclusion is to not consider, so to remove, a path during configuration drift evaluation. Patch (as the whole ResourceSummary instance) will be consumed by drift-detection-manager.
gianlucam76
force-pushed
the
ignore-drift
branch
from
4e3e74a to
474bebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating Profile/ClusterProfile with syncMode set to
ContinuousWithDriftDetectionuser will have the ability to specify set of paths for certain resources that need to be ignored during configuration drift evaluation.User can use the field
DriftExclusions.This is helpful for instance when a Deployment is deployed by Sveltos along an autoscaler. Autoscaler will scale
replicasup and down. So we don't want a replicas change to be seen as a configuration drift.addon-manager will pass resources that need to be watched for configuration drift and will transform DriftExclusions into a slices of
Patch.Operation is always set to remove as the goal of a DriftExclusion is to not consider, so to remove, a path during configuration drift evaluation.
Patch (as the whole ResourceSummary instance) will be consumed by drift-detection-manager.