Merge dev to main #304
Merged
Merge dev to main #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request projectsveltos#297 from gianlucam76/main
Expose method to create ConflicError
When reporting conflict, add list of conflicting Clusterprofile/Profiles
A Kubernetes resource can be deployed in a managed cluster only by a ClusterProfile/Profile instance Before this PR, if two ClusterProfile/Profile instances: 1. matched the same cluster 2. referenced the same ConfigMap the resources contained in the ConfigMap were successfully deployed and neither of the ClusterProfile/Profile instance reported an error. After this PR, the resources contained in the ConfigMap will still be successfully deployed. But while the first ClusterProfile/Profile will succeed, the second one will report a conflict with the first one. This behavior change is implemented as part of introducing the concept of tier in ClusterProfile/Profile. Allowing only one ClusterProfile/Profile instance to deploy a given Kubernetes resources, allows to handle the scenario where different ClusterProfile/Profile instances with different tiers want to deploy the same resource (and let the profile with lower tier win the conflict).
Deployed resource validation
Instead of returning a boolen indicating whether resource exists or not, return the resource version (only existing objects have that field set).
ValidateObjectForUpdate: Return resource version
Prepare for release v0.30.0
gianlucam76
added a commit
that referenced
this pull request
May 28, 2024
Merge pull request #304 from gianlucam76/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post release v0.30.0