Testing: disable looking up GCP credentials #9900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up of projectnessie#9866 (and it's revert projectnessie#9899). The stack traces indicate that the global-tracer field init race happens when `BigTableBackendBuilder` tries to fetch the GCP credentials via `Instance<CredentialsProvider>`, which eventually lets the Google client try to find the default app-credentials, which then implicitly initializes OpenCensus->OpenTelemetry. The workaround here is to add a new undocumented configuration option to disable GCP credentials lookup, which is also not necessary when using the BT emulator.
dimas-b
reviewed
Nov 11, 2024
| googleCredentialsException = e; | ||
| // The disableCredentialsLookupForTests() is only used for tests and only to prevent the | ||
| // OpenTelemetry/global-tracer static-field initialization race described in #9866 | ||
| if (!bigTableConfig.disableCredentialsLookupForTests()) { |
There was a problem hiding this comment.
I'm not sure "ForTests" actually adds any guardrails, but it makes the java code look odd. Could you name the java method simply as disableCredentialsLookup()? I suppose end users will get enough warning from having "credentials" in the name.
There was a problem hiding this comment.
... and of course, we'll keep it undocumented (other than javadoc)
There was a problem hiding this comment.
Does it really matter? The parameter won't show up in any documentation
There was a problem hiding this comment.
IMHO, the code reads awkwardly, but up to you :)
dimas-b
approved these changes
Nov 11, 2024
| googleCredentialsException = e; | ||
| // The disableCredentialsLookupForTests() is only used for tests and only to prevent the | ||
| // OpenTelemetry/global-tracer static-field initialization race described in #9866 | ||
| if (!bigTableConfig.disableCredentialsLookupForTests()) { |
There was a problem hiding this comment.
IMHO, the code reads awkwardly, but up to you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #9866 (and it's revert #9899). The stack traces indicate that the global-tracer field init race happens when
BigTableBackendBuildertries to fetch the GCP credentials viaInstance<CredentialsProvider>, which eventually lets the Google client try to find the default app-credentials, which then implicitly initializes OpenCensus->OpenTelemetry.The workaround here is to add a new undocumented configuration option to disable GCP credentials lookup, which is also not necessary when using the BT emulator.