Fix jwk-json-leak template matcher #11414
Open
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template / PR Information
According to the RFC 7517 section 4.5:
On the other hand, section 4.1 mentions:
With that in mind, I've changed the
kid
from the template's matcher tokty
as there is a higher chance that this field will be present.Template Validation
I've validated this template locally?
Example
jwks.json
file from Appendix A of the RFC:I hosted this file locally as visible and then with the
kid
fields removed. The new template matches the file in both cases.