Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update regex #306

Merged
merged 3 commits into from
Jun 27, 2024
Merged

update regex #306

merged 3 commits into from
Jun 27, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #305

go run . -d test_.google.com

   ___   _____  __              
  / _ | / __/ |/ /_ _  ___ ____ 
 / __ |_\ \/    /  ' \/ _  / _ \
/_/ |_/___/_/|_/_/_/_/\_,_/ .__/
                         /_/ 

                projectdiscovery.io

[INF] Current asnmap version v1.1.0 (latest)

@dogancanbakir dogancanbakir requested a review from ehsandeep March 18, 2024 11:27
@dogancanbakir dogancanbakir self-assigned this Mar 18, 2024
@dogancanbakir dogancanbakir linked an issue Apr 2, 2024 that may be closed by this pull request
json: cannot unmarshal string into Go value of type []*asnmap.Response #305
Closed
@dogancanbakir dogancanbakir requested a review from Mzack9999 April 2, 2024 08:53
Mzack9999
Mzack9999 requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using https://pkg.go.dev/github.com/asaskevich/govalidator#IsDNSName? It's more permissive than the previous regex and at the same time covers more edge cases with various characters

@dogancanbakir dogancanbakir requested a review from Mzack9999 April 3, 2024 12:50
@dogancanbakir
Copy link
Member Author

It wasn't working as expected, reverted.

Mzack9999
Mzack9999 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - but under further review the error seems legitimate as domains with _ as invalid by RFC and will not trigger any query by ip to the backend. The issue seems related to a 400 unexpected response from the server. I guess some additional layer recently introduced

image

@ehsandeep ehsandeep merged commit aae8aae into dev Jun 27, 2024
4 checks passed
@ehsandeep ehsandeep deleted the update_regex branch June 27, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json: cannot unmarshal string into Go value of type []*asnmap.Response
3 participants
@dogancanbakir @ehsandeep @Mzack9999