Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 7/31 #1889

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Merge 7/31 #1889

merged 5 commits into from
Jul 31, 2024

Conversation

dczulada
Copy link
Contributor

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

* Relax RV error if additional information is provided

* avoid exeception for Risk Variable Smoking Status in CMS1218

* only render the raw json from the individual result for risk variable

* updated unit test
* setup FilterTest as a job

* Update unit tests

* Include Filtering tests in the product creation status

* more test updates

* update api_measure_evaluator to wait longer for filter tests to be created

* update rexml
* Use updated IG for CMS Cat III

* point to git branch

* update rexml for bundle audit

* Cypress Certification is no longer shown in the HTML patient view

* update schematron to the one published on 7/25

* point to gem, not branch of cqm-reports
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (4c9a747) to head (cc4e6ae).
Report is 49 commits behind head on cypress_v7.

Additional details and impacted files
@@              Coverage Diff               @@
##           cypress_v7    #1889      +/-   ##
==============================================
- Coverage       96.39%   96.31%   -0.08%     
==============================================
  Files             156      157       +1     
  Lines            7103     7091      -12     
==============================================
- Hits             6847     6830      -17     
- Misses            256      261       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dczulada dczulada merged commit efe851a into cypress_v7 Jul 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant