Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for ami and ssh ed25519 #1822

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Changes for ami and ssh ed25519 #1822

merged 1 commit into from
Jun 27, 2023

Conversation

luis1van
Copy link
Collaborator

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@luis1van luis1van requested a review from dczulada June 26, 2023 21:19
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e391a02) 96.70% compared to head (c1f9e1b) 96.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1822   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files         156      156           
  Lines        7050     7050           
=======================================
  Hits         6818     6818           
  Misses        232      232           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dczulada dczulada merged commit 2f8a114 into master Jun 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants