Allow connect on Http2ProtocolOptions when Websockets are enabled #6846
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajat Vig <[email protected]>
rajatvig
force-pushed
the
AllowConnect
branch
from
45da937 to
98bfa41
Compare
rajatvig
added
the
release-note/small
Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6846 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 133 133
Lines 20026 20030 +4
=======================================
+ Hits 16232 16236 +4
Misses 3500 3500
Partials 294 294
|
rajatvig
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
davinci26 and
clayton-gonsalves
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should possibly address part of #3371 and possibly knative/serving#13083 when using Knative with Contour.
Signed-off-by: Rajat Vig [email protected]