Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation: use EndpointSlices by default #6149

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Implementation: use EndpointSlices by default #6149

merged 10 commits into from
Apr 10, 2024

Conversation

izturn
Copy link
Member

@izturn izturn commented Feb 1, 2024 •
edited by sunjayBhatia
Loading

Signed-off-by: Gang Liu [email protected]

Closes: #5891

@izturn izturn requested a review from a team as a code owner February 1, 2024 08:25
@izturn izturn requested review from skriss and sunjayBhatia and removed request for a team February 1, 2024 08:25
@izturn izturn self-assigned this Feb 1, 2024
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and clayton-gonsalves and removed request for a team February 1, 2024 08:26
@izturn
change log
4233def 
Signed-off-by: gang.liu <[email protected]>
@izturn izturn added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Feb 1, 2024
@izturn
make lint happy
20ffdd1 
Signed-off-by: gang.liu <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (23a0297) to head (0a9814e).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6149   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         133      133           
  Lines       15800    15800           
=======================================
  Hits        12887    12887           
  Misses       2617     2617           
  Partials      296      296
Files Coverage Δ
pkg/config/parameters.go 88.03% <ø> (ø)

@izturn
sync & fix conflict
4903f7b 
Signed-off-by: gang.liu <[email protected]>
@izturn
make lint happy
82aa19f 
Signed-off-by: gang.liu <[email protected]>
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2024
@skriss skriss added release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2024
skriss
skriss requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fine-tuning on the changelog, but otherwise LGTM, thanks @izturn

changelogs/unreleased/6149-izturn-minor.md Outdated Show resolved Hide resolved
changelogs/unreleased/6149-izturn-minor.md Outdated Show resolved Hide resolved
changelogs/unreleased/6149-izturn-minor.md Show resolved Hide resolved
sunjayBhatia
sunjayBhatia reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple last nits, otherwise with Steve's comments LGTM

apis/projectcontour/v1alpha1/contourconfig.go Outdated Show resolved Hide resolved
apis/projectcontour/v1alpha1/contourconfig.go Outdated Show resolved Hide resolved
apis/projectcontour/v1alpha1/contourconfig.go Outdated Show resolved Hide resolved
pkg/config/parameters.go Show resolved Hide resolved
@sunjayBhatia
Copy link
Member

LGTM, will leave for @skriss with last signoff

@izturn izturn requested a review from skriss March 19, 2024 01:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 8, 2024
@skriss skriss merged commit 6f7010a into projectcontour:main Apr 10, 2024
26 checks passed
SamMHD pushed a commit to SamMHD/contour that referenced this pull request Sep 8, 2024
@izturn @SamMHD
use EndpointSlices by default (projectcontour#6149)
d1915c3 
Closes projectcontour#5891.

Signed-off-by: gang.liu <[email protected]>
Signed-off-by: Saman Mahdanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@skriss skriss skriss approved these changes

@davinci26 davinci26 Awaiting requested review from davinci26 davinci26 was automatically assigned from projectcontour/contour-reviewers

@clayton-gonsalves clayton-gonsalves Awaiting requested review from clayton-gonsalves clayton-gonsalves was automatically assigned from projectcontour/contour-reviewers

Assignees

@izturn izturn

Labels
release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use EndpointSlices by default
3 participants
@izturn @sunjayBhatia @skriss