Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate certs and private keys for tests #6100

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

tsaarni
Copy link
Member

@tsaarni tsaarni commented Jan 19, 2024

This PR refactors feature tests:

  • Replace hardcoded test certs and private key with generated ones
  • Replace secrets instantiated inline with functions that construct them

There are still certificates in internal/fixture/certificate_constants.go which are used outside featuretests. Since the change is getting large and risk of merge conflicts with other PRs increase, I'd prefer including only featuretest related certs in this PR.

Related to #6079 (comment)

@tsaarni tsaarni requested a review from a team as a code owner January 19, 2024 17:29
@tsaarni tsaarni requested review from skriss and sunjayBhatia and removed request for a team January 19, 2024 17:29
@tsaarni tsaarni added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 19, 2024
@sunjayBhatia sunjayBhatia requested review from a team, izturn and clayton-gonsalves and removed request for a team January 19, 2024 17:29
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (4ae0bfa) 78.85% compared to head (e3a0acf) 78.82%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6100      +/-   ##
==========================================
- Coverage   78.85%   78.82%   -0.03%     
==========================================
  Files         138      138              
  Lines       19731    19765      +34     
==========================================
+ Hits        15558    15580      +22     
- Misses       3870     3878       +8     
- Partials      303      307       +4     
Files Coverage Δ
internal/featuretests/v3/envoy.go 99.08% <100.00%> (-0.01%) ⬇️
...ernal/provisioner/objects/deployment/deployment.go 88.98% <100.00%> (-0.05%) ⬇️
internal/featuretests/kubernetes.go 83.78% <73.80%> (-16.22%) ⬇️

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Copy link
Member

@izturn izturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor

@sunjayBhatia sunjayBhatia merged commit 26ddb0f into projectcontour:main Jan 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants