-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate certs and private keys for tests #6100
Conversation
Signed-off-by: Tero Saarni <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6100 +/- ##
==========================================
- Coverage 78.85% 78.82% -0.03%
==========================================
Files 138 138
Lines 19731 19765 +34
==========================================
+ Hits 15558 15580 +22
- Misses 3870 3878 +8
- Partials 303 307 +4
|
Signed-off-by: Tero Saarni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactor
Signed-off-by: Tero Saarni <[email protected]>
This PR refactors feature tests:
There are still certificates in internal/fixture/certificate_constants.go which are used outside featuretests. Since the change is getting large and risk of merge conflicts with other PRs increase, I'd prefer including only featuretest related certs in this PR.
Related to #6079 (comment)