Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum permissions on remaining workflows #6072

Conversation

sunjayBhatia
Copy link
Member

Fixes codeql workflow to add write permissions

Fixes codeql workflow to add write permissions

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 11, 2024
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner January 11, 2024 18:49
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team and davinci26 and removed request for a team January 11, 2024 18:49
@sunjayBhatia
Copy link
Member Author

codeql failed previously here: https://github.com/projectcontour/contour/actions/runs/7493004808

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16fa671) 78.81% compared to head (fc191b1) 78.81%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6072   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         138      138           
  Lines       19778    19778           
=======================================
  Hits        15589    15589           
  Misses       3886     3886           
  Partials      303      303           

@sunjayBhatia sunjayBhatia changed the title Update permissions on remaining workflows Update minimum permissions on remaining workflows Jan 11, 2024
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sunjayBhatia sunjayBhatia merged commit cc85f47 into projectcontour:main Jan 11, 2024
30 checks passed
@sunjayBhatia sunjayBhatia deleted the github-workflow-token-min-permissions-non-pr branch January 11, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants