Implementation: External Processing support #5867

izturn · 2023-10-19T03:44:31Z

Signed-off-by: Gang Liu [email protected]

Implementation proposal to address #5123

Signed-off-by: gang.liu <[email protected]>

izturn · 2023-10-19T05:56:21Z

Due to the current proposal status, relevant unit tests have not been added yet

Signed-off-by: gang.liu <[email protected]>

codecov · 2023-10-19T06:16:37Z

Codecov Report

Attention: Patch coverage is 17.76316% with 250 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5b0d091). Learn more about missing BASE report.
Report is 44 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/dag/httpproxy_processor.go	28.98%	87 Missing and 11 partials ⚠️
internal/envoy/v3/listener.go	6.89%	54 Missing ⚠️
internal/envoy/v3/route.go	0.00%	42 Missing and 1 partial ⚠️
cmd/contour/serve.go	4.76%	20 Missing ⚠️
cmd/contour/servecontext.go	9.09%	19 Missing and 1 partial ⚠️
internal/xdscache/v3/listener.go	38.88%	11 Missing ⚠️
internal/fixture/httpproxy.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5867   +/-   ##
=======================================
  Coverage        ?   80.06%           
=======================================
  Files           ?      133           
  Lines           ?    20279           
  Branches        ?        0           
=======================================
  Hits            ?    16237           
  Misses          ?     3736           
  Partials        ?      306

Files with missing lines	Coverage Δ
internal/dag/dag.go	`98.78% <ø> (ø)`
internal/sorter/sorter.go	`100.00% <ø> (ø)`
pkg/config/parameters.go	`88.05% <ø> (ø)`
internal/fixture/httpproxy.go	`86.27% <0.00%> (ø)`
internal/xdscache/v3/listener.go	`89.47% <38.88%> (ø)`
cmd/contour/serve.go	`21.36% <4.76%> (ø)`
cmd/contour/servecontext.go	`81.01% <9.09%> (ø)`
internal/envoy/v3/route.go	`76.56% <0.00%> (ø)`
internal/envoy/v3/listener.go	`91.13% <6.89%> (ø)`
internal/dag/httpproxy_processor.go	`85.40% <28.98%> (ø)`

github-actions · 2023-11-03T00:18:49Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-09-09T00:25:19Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-09-24T00:25:16Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-10-21T00:26:51Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

lorem-dev · 2024-11-01T08:03:06Z

Anyone, please review it 🙏 🙏 🙏

apis/projectcontour/v1/helpers.go

Hozeri · 2024-11-01T09:21:26Z

Please review it

internal/dag/dag.go

lorem-dev · 2024-11-01T09:43:13Z

@izturn, could you please squash the commits with linting fixes and format the commit messages as well?

izturn · 2024-11-01T10:11:16Z

@izturn, could you please squash the commits with linting fixes and format the commit messages as well?

ok, i will update it later

Signed-off-by: gang.liu <[email protected]>

izturn · 2024-11-04T03:23:26Z

@izturn, could you please squash the commits with linting fixes and format the commit messages as well?

done

donatgorbachev · 2024-11-04T09:39:29Z

@skriss, could you please review this PR 🙏

github-actions · 2024-11-21T00:26:48Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-12-06T00:27:48Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-12-23T00:27:10Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

izturn added 15 commits September 28, 2023 17:33

init commit for extProc

39d0717

Signed-off-by: gang.liu <[email protected]>

build pass

98f43de

Signed-off-by: gang.liu <[email protected]>

Merge remote-tracking branch 'upstream/main' into feat/ext-proc

b54c663

insert extProc by phase(TODO)

ca308a4

Signed-off-by: gang.liu <[email protected]>

make generate

f7a1906

Signed-off-by: gang.liu <[email protected]>

set default for extProc's params

84bafd4

Signed-off-by: gang.liu <[email protected]>

clean up

922668f

Signed-off-by: gang.liu <[email protected]>

more todo

9c54782

Signed-off-by: gang.liu <[email protected]>

more log

07363a8

Signed-off-by: gang.liu <[email protected]>

comments & more

99a3b52

Signed-off-by: gang.liu <[email protected]>

add filters by phase & refactor

2c9de3f

Signed-off-by: gang.liu <[email protected]>

bugfix & duplicate processing check

d1a4011

Signed-off-by: gang.liu <[email protected]>

sync & fix conflict

7d2793f

Signed-off-by: gang.liu <[email protected]>

Merge remote-tracking branch 'upstream/main' into feat/extproc

5dcfcf8

fix ut

024a515

Signed-off-by: gang.liu <[email protected]>

izturn requested a review from a team as a code owner October 19, 2023 03:44

izturn requested review from skriss and sunjayBhatia and removed request for a team October 19, 2023 03:44

izturn self-assigned this Oct 19, 2023

izturn added area/infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note/infra An infrastructure update for the release notes. labels Oct 19, 2023

make lint happy

04d9840

Signed-off-by: gang.liu <[email protected]>

izturn added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2023

izturn mentioned this pull request Oct 25, 2023

[Feature Discussion] The ways to extend/custom functionalities for Envoy: WASM vs. Lua vs. External Processing vs. GO filter #5123

Closed

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 9, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2024

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 21, 2024

donatgorbachev reviewed Nov 1, 2024

View reviewed changes

apis/projectcontour/v1/helpers.go Outdated Show resolved Hide resolved

donatgorbachev reviewed Nov 1, 2024

View reviewed changes

internal/dag/dag.go Outdated Show resolved Hide resolved

izturn added 2 commits November 4, 2024 11:12

Merge remote-tracking branch 'upstream/main' into feat/extproc

7da9c30

fix typo & little refactor

f6b0772

Signed-off-by: gang.liu <[email protected]>

izturn added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 4, 2024

izturn requested a review from donatgorbachev November 4, 2024 03:21

izturn removed the release-note/infra An infrastructure update for the release notes. label Nov 4, 2024

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 21, 2024

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 6, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation: External Processing support #5867

Implementation: External Processing support #5867

izturn commented Oct 19, 2023 •

edited

Loading

izturn commented Oct 19, 2023

codecov bot commented Oct 19, 2023 •

edited

Loading

github-actions bot commented Nov 3, 2023

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Oct 21, 2024

lorem-dev commented Nov 1, 2024

Hozeri commented Nov 1, 2024

lorem-dev commented Nov 1, 2024

izturn commented Nov 1, 2024

izturn commented Nov 4, 2024

donatgorbachev commented Nov 4, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 23, 2024

Implementation: External Processing support #5867

Are you sure you want to change the base?

Implementation: External Processing support #5867

Conversation

izturn commented Oct 19, 2023 • edited Loading

izturn commented Oct 19, 2023

codecov bot commented Oct 19, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 3, 2023

github-actions bot commented Sep 9, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Oct 21, 2024

lorem-dev commented Nov 1, 2024

Hozeri commented Nov 1, 2024

lorem-dev commented Nov 1, 2024

izturn commented Nov 1, 2024

izturn commented Nov 4, 2024

donatgorbachev commented Nov 4, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 23, 2024

izturn commented Oct 19, 2023 •

edited

Loading

codecov bot commented Oct 19, 2023 •

edited

Loading