-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bootstrap configuration to use dynamic runtime layers #5848
Conversation
Hi @MeenuyD! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MeenuyD thanks for the PR!
A few things that will need to be fixed:
- please sign off your commits (
git commit --signoff
) to make sure the DCO check passes - We also wanted to refactor this file https://github.com/projectcontour/contour/blob/main/internal/envoy/v3/runtime.go to move the regex program size settings into the
runtimeKV
settings at this higher level - The previous bullet and your existing changes will need appropriate unit test changes
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
Signed-off-by: MeenuyD <[email protected]>
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
In contour/internal/envoy/v3/bootstrap.go, removed the static bootstrap runtime layer. Instead, this modifies the bootstrap configuration to use dynamic runtime layers, allowing for more flexibility and consolidation of the codebase.
#5845