Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use EndpointSlices by default #5891

Closed
skriss opened this issue Oct 24, 2023 · 4 comments · Fixed by #6149
Closed

use EndpointSlices by default #5891

skriss opened this issue Oct 24, 2023 · 4 comments · Fixed by #6149
Assignees
@izturn
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.29.0

Comments

@skriss
Copy link
Member

skriss commented Oct 24, 2023

#5745 added opt-in support for EndpointSlices. This issue is to switch to using EndpointSlices by default, once #5745 has been sufficiently validated.

Adding this to 1.28 milestone but can always be pushed out if needed.
@skriss skriss added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2023
@skriss skriss added this to the 1.28.0 milestone Oct 24, 2023
@skriss skriss added this to Contour Oct 24, 2023
@skriss skriss moved this to Todo in Contour Oct 24, 2023
@izturn izturn self-assigned this Nov 1, 2023
@izturn
Copy link
Member

izturn commented Nov 1, 2023

i'd like to work on it

@skriss
Copy link
Member Author

skriss commented Jan 30, 2024

@davinci26 @clayton-gonsalves it'd be great to get an update from you all on using EndpointSlices - have you had any issues we need to know about before flipping it to be the default?

@davinci26
Copy link
Contributor

We have been using it in production for a while with no issues.

We also noticed significant cpu reduction before and after we deployed the change in the controller when parsing large deployments

@izturn izturn mentioned this issue Feb 1, 2024
Merged
@skriss
Copy link
Member Author

skriss commented Feb 1, 2024

We're going to move this to 1.29, so we've got a full release cycle to run CI etc. with the new default.

@skriss skriss modified the milestones: 1.28.0, 1.29.0 Feb 1, 2024
@sunjayBhatia sunjayBhatia moved this from Todo to In Progress in Contour Feb 1, 2024
skriss pushed a commit that referenced this issue Apr 10, 2024
@izturn
use EndpointSlices by default (#6149)
6f7010a 
Closes #5891.

Signed-off-by: gang.liu <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Contour Apr 10, 2024
@skriss skriss mentioned this issue May 6, 2024
Open
SamMHD pushed a commit to SamMHD/contour that referenced this issue Sep 8, 2024
@izturn @SamMHD
use EndpointSlices by default (projectcontour#6149)
d1915c3 
Closes projectcontour#5891.

Signed-off-by: gang.liu <[email protected]>
Signed-off-by: Saman Mahdanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izturn izturn

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: Done
Milestone
1.29.0
Development

Successfully merging a pull request may close this issue.

Implementation: use EndpointSlices by default izturn/contour
3 participants
@skriss @davinci26 @izturn