Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing static "base" Runtime layer from bootstrap #5845

Closed
sunjayBhatia opened this issue Oct 12, 2023 · 0 comments · Fixed by #6063
Closed

Consider removing static "base" Runtime layer from bootstrap #5845

sunjayBhatia opened this issue Oct 12, 2023 · 0 comments · Fixed by #6063
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Oct 12, 2023 •
edited
Loading

At the moment we also use this helper from internal/envoy/v3 to build up the bootstrap config base RTDS layer:

contour/internal/envoy/v3/bootstrap.go

Line 169 in f52ad06

StaticLayer: baseRuntimeLayer(),

We may be able to get rid of that static bootstrap runtime layer since it was introduced in #4379 and just serve dynamic layers instead (added in #4387) which would mean we can refactor and consolidate a bit.

Originally posted by @sunjayBhatia in #5827 (comment)
@sunjayBhatia sunjayBhatia added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 12, 2023
@sunjayBhatia sunjayBhatia mentioned this issue Oct 12, 2023
Merged
@MeenuyD MeenuyD mentioned this issue Oct 12, 2023
Closed
@lubronzhan lubronzhan mentioned this issue Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove static base runtime layer from bootstrap lubronzhan/contour
1 participant
@sunjayBhatia