Remove initial readiness probe delay (#6099)

Signed-off-by: Sunjay Bhatia <[email protected]>
projectcontour · Jan 22, 2024 · 0fc3b5d · 0fc3b5d
1 parent 4ae0bfa
commit 0fc3b5d
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/changelogs/unreleased/6099-sunjayBhatia-minor.md b/changelogs/unreleased/6099-sunjayBhatia-minor.md
@@ -0,0 +1,5 @@
+## Remove Contour container readiness probe initial delay
+
+The Contour Deployment Contour server container previously had its readiness probe `initialDelaySeconds` field set to 15.
+This has been removed from the example YAML manifests and Gateway Provisioner generated Contour Deployment since as of [PR #5672](https://github.com/projectcontour/contour/pull/5672) Contour's xDS server will not start or serve any configuration (and the readiness probe will not succeed) until the existing state of the cluster is synced.
+In clusters with few resources this will improve the Contour Deployment's update/rollout time as initial startup time should be low.
diff --git a/examples/contour/03-contour.yaml b/examples/contour/03-contour.yaml
@@ -65,7 +65,6 @@ spec:
         readinessProbe:
           tcpSocket:
             port: 8001
-          initialDelaySeconds: 15
           periodSeconds: 10
         volumeMounts:
           - name: contourcert

diff --git a/examples/render/contour-deployment.yaml b/examples/render/contour-deployment.yaml
@@ -9053,7 +9053,6 @@ spec:
         readinessProbe:
           tcpSocket:
             port: 8001
-          initialDelaySeconds: 15
           periodSeconds: 10
         volumeMounts:
           - name: contourcert

diff --git a/examples/render/contour-gateway.yaml b/examples/render/contour-gateway.yaml
@@ -9056,7 +9056,6 @@ spec:
         readinessProbe:
           tcpSocket:
             port: 8001
-          initialDelaySeconds: 15
           periodSeconds: 10
         volumeMounts:
           - name: contourcert

diff --git a/examples/render/contour.yaml b/examples/render/contour.yaml
@@ -9053,7 +9053,6 @@ spec:
         readinessProbe:
           tcpSocket:
             port: 8001
-          initialDelaySeconds: 15
           periodSeconds: 10
         volumeMounts:
           - name: contourcert

diff --git a/internal/provisioner/objects/deployment/deployment.go b/internal/provisioner/objects/deployment/deployment.go
@@ -176,11 +176,10 @@ func DesiredDeployment(contour *model.Contour, image string) *appsv1.Deployment
 					},
 				},
 			},
-			TimeoutSeconds:      int32(1),
-			InitialDelaySeconds: int32(15),
-			PeriodSeconds:       int32(10),
-			SuccessThreshold:    int32(1),
-			FailureThreshold:    int32(3),
+			TimeoutSeconds:   int32(1),
+			PeriodSeconds:    int32(10),
+			SuccessThreshold: int32(1),
+			FailureThreshold: int32(3),
 		},
 		TerminationMessagePath:   "/dev/termination-log",
 		TerminationMessagePolicy: corev1.TerminationMessageReadFile,