Metadata Fix #2742
Open
Metadata Fix #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expected syntax: |
sysopenci
added
Pending Developer Approval
|
|
||
| - if (!p_bcb->p_tx_msg || !p_ccb_bind) { | ||
| + if (!p_bcb->p_tx_msg) { | ||
| + log::warn("abhadour Received browse packet with no browse data peer:{} lcid:0x{:04x}", p_bcb->peer_addr, |
There was a problem hiding this comment.
Logs should be clean.
| /* if no ccbs bound to this lcb, disconnect */ | ||
| - if (!bind) { | ||
| + if (p_ccb_bind == nullptr) { | ||
| + log::warn("abhadour Ignoring incoming browse request and closing channel from peer:{} lcid:0x{:04x}", |
There was a problem hiding this comment.
Logs should be clean.
| ******************************************************************************/ | ||
| +namespace { | ||
| +bool is_valid_role_check(const tAVCT_CCB* p_ccb) { | ||
| + log::warn("abhadour Inside valid role check"); |
There was a problem hiding this comment.
Logs should be clean in all places.
There was a problem hiding this comment.
PR for custom EB, will clean up after confirmation
gowthambabu92
suggested changes
Dec 4, 2024
| When reconnecting pixel some times metadata is not synced. | ||
|
|
||
| Issue: bt-stack issuing two AVRC browse channel, one as acceptor, | ||
| other as initator, which is causing collision in lcid and resulting |
There was a problem hiding this comment.
Can we mention the aosp patch from where these changes are taken?
|
Expected syntax: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.