Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding api support for sensor HAL. #1269

Open
wants to merge 1 commit into
base: celadon/r/mr0/stable
Choose a base branch
from

Conversation

RajaniRanjan
Copy link
Contributor

@RajaniRanjan RajaniRanjan commented Nov 16, 2021

poll
batch
activate
flush

setDelay - is deprecated in Hal version 1.3 and
will not be called by fwk any more. where as
setDelay functionalities are handled by batch api

in pass through mode. re-entry should not be called by fwk. but its getting called and sensor service dies
thats the reason we comment portion of the code in Sensor.cpp

Tracked-On: OAM-99160
Signed-off-by: [email protected]
Signed-off-by: rranjan [email protected]

Copy link
Contributor

@rajucm2007 rajucm2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

Copy link
Contributor

@JaikrishnaNemallapudi JaikrishnaNemallapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From 6a98af52dae360d5a9aaede3073365ff8cdff933 Mon Sep 17 00:00:00 2001
From: rajucm <[email protected]>
Date: Tue, 16 Nov 2021 11:37:17 +0530
Subject: [PATCH] [sensor-hal] Isonsor poll re-entry causes issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isonsor typo

Date: Tue, 16 Nov 2021 11:37:17 +0530
Subject: [PATCH] [sensor-hal] Isonsor poll re-entry causes issue

poll re-entry is not expected in passthrogh implementation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo passthrogh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please explain the issue caused by poll re-entry

@RajaniRanjan RajaniRanjan force-pushed the sensors_service branch 4 times, most recently from 57468da to af28036 Compare November 23, 2021 04:33
batch
activate
flush

setDelay - is deprecated in Hal version 1.3 and
will not be called by fwk any more. where as
setDelay functionalities are handled by batch api

Tracked-On: OAM-99160
Signed-off-by: [email protected]
Signed-off-by: rranjan [email protected]
@RajaniRanjan RajaniRanjan force-pushed the sensors_service branch 2 times, most recently from aea0fe9 to f8cdd1d Compare November 23, 2021 05:34
@RajaniRanjan
Copy link
Contributor Author

not required now

@RajaniRanjan RajaniRanjan reopened this Jan 4, 2022
@sysopenci sysopenci added the Stale Stale label for inactive open prs label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale label for inactive open prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants