-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding api support for sensor HAL. #1269
base: celadon/r/mr0/stable
Are you sure you want to change the base?
adding api support for sensor HAL. #1269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From 6a98af52dae360d5a9aaede3073365ff8cdff933 Mon Sep 17 00:00:00 2001 | ||
From: rajucm <[email protected]> | ||
Date: Tue, 16 Nov 2021 11:37:17 +0530 | ||
Subject: [PATCH] [sensor-hal] Isonsor poll re-entry causes issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isonsor typo
Date: Tue, 16 Nov 2021 11:37:17 +0530 | ||
Subject: [PATCH] [sensor-hal] Isonsor poll re-entry causes issue | ||
|
||
poll re-entry is not expected in passthrogh implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo passthrogh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please explain the issue caused by poll re-entry
57468da
to
af28036
Compare
batch activate flush setDelay - is deprecated in Hal version 1.3 and will not be called by fwk any more. where as setDelay functionalities are handled by batch api Tracked-On: OAM-99160 Signed-off-by: [email protected] Signed-off-by: rranjan [email protected]
aea0fe9
to
f8cdd1d
Compare
not required now |
poll
batch
activate
flush
setDelay - is deprecated in Hal version 1.3 and
will not be called by fwk any more. where as
setDelay functionalities are handled by batch api
in pass through mode. re-entry should not be called by fwk. but its getting called and sensor service dies
thats the reason we comment portion of the code in Sensor.cpp
Tracked-On: OAM-99160
Signed-off-by: [email protected]
Signed-off-by: rranjan [email protected]