Mtl video playback fix #178
Conversation
Adding of format, usage, and modifier supported combination to a driver is getting skipped due to invalid condition check. Fix the issue by skipping addition of supported combination only on dual GPU case and dGPU. Tests done: - Android boot to UI - Video playback Tracked-On: OAM-129167 Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
Tests done: - Android boot to UI - Video playback Tracked-On: OAM-129167 Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
feijiang1,
gkdeepa,
renchenglei,
yaoxinshi-intel,
YuanjunHuang and
yyao3
| (drv->gpu_grp_type & GPU_GRP_TYPE_HAS_VIRTIO_GPU_BLOB_BIT)) { | ||
| if (((drv->gpu_grp_type & GPU_GRP_TYPE_HAS_INTEL_IGPU_BIT) || | ||
| (drv->gpu_grp_type & GPU_GRP_TYPE_HAS_VIRTIO_GPU_BLOB_BIT)) | ||
| && (GEN_VERSION_X10(i915) == 125)) { |
There was a problem hiding this comment.
There is code:
bool i915_has_tile4(struct i915_device *i915)
{
return i915->graphics_version >= 125 || i915->is_mtl;
}
It seems MTL should support Tile4 format. Upper code need be refined.
There was a problem hiding this comment.
misunderstand the change, we just skip for igpu+dgpu case, while MTL can satisfy the check, then is also skipped.
sysopenci
removed request for
renchenglei,
yyao3,
gkdeepa,
YuanjunHuang and
yaoxinshi-intel
sysopenci
added
Developer Approved
and removed
Pending Developer Approval
|
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
added
Engineering Build Successful
|
Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details. |
|
Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon-merge/924 |
No description provided.