Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong graphics version #143

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix wrong graphics version #143

merged 1 commit into from
Sep 23, 2024

Conversation

chenyanxzhu
Copy link
Contributor

Unify some struct member. Clean duplicated code.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Aug 16, 2024
@sysopenci
Copy link

Improper Commit Message
Proper Tracked on value is not present in
commit message,make sure Tracked-on: jira-ticket is present

@sysopenci
Copy link

Improper Commit Message
Proper Tracked on value is not present in
commit message,make sure Tracked-on: jira-ticket is present

@chenyanxzhu
Correct wrong graphics version
63f9875 
Unify some struct member. Clean duplicated code.

Tracked-On: OAM-123685
Signed-off-by: ZhuChenyanX <[email protected]>
feijiang1
feijiang1 approved these changes Sep 19, 2024
View reviewed changes
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Sep 19, 2024
@sysopenci sysopenci removed the Pending Developer Approval Pending Developer Approval label Sep 19, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@chenyanxzhu
Copy link
Contributor Author

LGTM

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Developer Approved and removed Developer Approved Pending Developer Approval Pending Developer Approval labels Sep 21, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 650e7fc into projectceladon:celadon/u/mr0/master Sep 23, 2024
37 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feijiang1 feijiang1 feijiang1 approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyanxzhu @sysopenci @feijiang1