Cast screen kms #142
Cast screen kms #142
Conversation
|
Improper Commit Message |
sysopenci
added
Pending Developer Approval
|
Improper Commit Message |
yhe39
force-pushed
the
cast-screen-kms
branch
from
a0d9257 to
15e5fa1
Compare
sysopenci
requested review from
feijiang1,
gkdeepa,
renchenglei,
YuanjunHuang and
yyao3
yhe39
force-pushed
the
cast-screen-kms
branch
from
15e5fa1 to
3708ffa
Compare
|
@feijiang1 @phreer @chenyanxzhu the pr is updated, please check. |
yhe39
force-pushed
the
cast-screen-kms
branch
from
44f58c4 to
e964b92
Compare
cros_gralloc/cros_gralloc_driver.cc
Outdated
| return -ENODEV; | ||
| } | ||
|
|
||
| fd = open(node, O_RDWR, 0); |
There was a problem hiding this comment.
need check fd, here, upper log
drv_loge("Open new added node fail\n");
need be moved here
There was a problem hiding this comment.
in the line 136, checked the fd, the availabe_node calculate the available node, in line 152, availabe_node > 0 means has the available node, so the fd should be the workable fd.
I add the checks before, Chenyan comment that the checks are done above, so i remove the checks.
There was a problem hiding this comment.
Actually what i mean is that u can push this bloc code(line 163-190) into the for loop (line 145), and rm line 152-162. Just for reference. Also 'availabe_node' can be removed if change this way.
There was a problem hiding this comment.
agree, suggest to combine upper code to remove some duplicated code. Also please help add some comments here, for example, the second ivshmem device is for our screen cast purpose.
Also please add enough introduction in the commit description.
There was a problem hiding this comment.
Patch updated, i made changes to use the first available ivshm node to screen cast.
Please check.
yhe39
force-pushed
the
cast-screen-kms
branch
from
e964b92 to
b0ade11
Compare
Open the first available ivshm node. If it is sancout buffer with certain resolution, use the ivshm node to allocate buffer. Tracked-On: OAM-122966 Signed-off-by: He, Yue <[email protected]>
yhe39
force-pushed
the
cast-screen-kms
branch
from
b0ade11 to
0a3b75f
Compare
sysopenci
added
Developer Approved
and removed
Pending Developer Approval
|
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
merged commit 7d29ab0
into
projectceladon:celadon/u/mr0/master
|
Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/94 |
No description provided.