Fix static scan issues #17

xianju6x · 2024-03-21T01:33:12Z

Tracked-On: OAM-110031

jingdlu · 2024-03-21T06:27:30Z

crashlog/fsutils.h

@@ -89,6 +89,7 @@ static inline int dir_exists(const char *dirpath) {

    dir = opendir(dirpath);
    if (dir != NULL)
+        closedir(dirpath);


You may need to use { } for closedir and return 1.

jingdlu · 2024-03-21T06:28:47Z

crashlog/crashutils.c

    int file_exist = 0;

    if (source == NULL) {
        LOGE("source is NULL.\n");
        return file_exist;
    }
+    DIR *dir = opendir(DROPBOX_DIR);


why need to move opendir here?

Variable dir going out of scope leaks the storage it points to at line 171.

jingdlu · 2024-03-21T06:29:33Z

crashlog/crashutils.c

@@ -808,13 +808,17 @@ int process_info_and_error(char *filename, char *name) {
        snprintf(path, sizeof(path),"%s/%s", filename,tmp_data_name);
        snprintf(destion,sizeof(destion),"%s/%s", dir, tmp_data_name);
        do_copy_tail(path, destion, 0);
-        remove(path);


Why need to check the return value of remove()? What's the consequence?

CID 206964: (#2 of 2): Unchecked return value from library (CHECKED_RETURN)
5. check_return Calling remove(path) without checking return value. This library function may fail and return an error code. [Note: The source code implementation of the function has been overridden by a builtin model.]

jingdlu · 2024-03-21T06:35:06Z

crashlog/usercrash.c

+                LOGE("Failed to remove path %s\n", path);
+                free(key);
+                free(dir);
+                return -1;


If you return here, other code logic may not be executed like raise_event.

Ok, just check return value and print some logs

Tracked-On: OAM-110031 Signed-off-by: Zheng, XianjunX <[email protected]>

sysopenci · 2024-03-21T08:29:15Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-21T08:33:32Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-21T08:53:58Z

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-21T08:54:23Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-21T08:55:45Z

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-21T08:59:29Z

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-21T08:59:57Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-21T09:21:35Z

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-22T05:29:36Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T01:25:33Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T03:16:33Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T04:15:58Z

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T06:38:38Z

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:03:27Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:04:47Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:05:18Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:05:25Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:05:28Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:05:32Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:05:34Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:05:34Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T07:06:20Z

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T09:43:51Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T10:03:27Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T10:27:56Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T10:35:28Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T10:59:14Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T11:48:40Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T11:58:34Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T13:03:58Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-25T13:33:26Z

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-26T18:16:47Z

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-26T18:52:07Z

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-26T19:41:05Z

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci · 2024-03-26T23:53:51Z

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_smr0_apollo-merge/79

sysopenci added the Valid commit message label Mar 21, 2024

sysopenci requested review from gkdeepa, kwang13 and lchen43 March 21, 2024 01:36

jingdlu reviewed Mar 21, 2024

View reviewed changes

sysopenci added Valid commit message and removed Valid commit message labels Mar 21, 2024

xianju6x force-pushed the celadon/s/mr0/apollo branch from 039d4b9 to 5c4e945 Compare March 21, 2024 07:30

sysopenci added Valid commit message and removed Valid commit message labels Mar 21, 2024

Fix static scan issues

702833e

Tracked-On: OAM-110031 Signed-off-by: Zheng, XianjunX <[email protected]>

xianju6x force-pushed the celadon/s/mr0/apollo branch from 5c4e945 to 702833e Compare March 21, 2024 07:51

sysopenci added Valid commit message Developer Approved and removed Valid commit message labels Mar 21, 2024

jingdlu approved these changes Mar 22, 2024

View reviewed changes

kwang13 approved these changes Mar 22, 2024

View reviewed changes

sysopenci added the PR approved label Mar 22, 2024

sysopenci removed request for lchen43 and gkdeepa March 22, 2024 05:25

sysopenci removed the Developer Approved label Mar 22, 2024

sysopenci added the Developer Approved label Mar 25, 2024

sysopenci removed the Developer Approved label Mar 25, 2024

sysopenci added the Developer Approved label Mar 25, 2024

sysopenci merged commit a55a5d1 into projectceladon:celadon/s/mr0/apollo Mar 26, 2024
17 checks passed

Fix static scan issues #17

Fix static scan issues #17

Conversation

xianju6x commented Mar 21, 2024

jingdlu Mar 21, 2024

Choose a reason for hiding this comment

jingdlu Mar 21, 2024

Choose a reason for hiding this comment

xianju6x Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

jingdlu Mar 21, 2024

Choose a reason for hiding this comment

xianju6x Mar 21, 2024

Choose a reason for hiding this comment

jingdlu Mar 21, 2024

Choose a reason for hiding this comment

xianju6x Mar 21, 2024

Choose a reason for hiding this comment

sysopenci commented Mar 21, 2024

sysopenci commented Mar 21, 2024

sysopenci commented Mar 21, 2024

sysopenci commented Mar 21, 2024

sysopenci commented Mar 21, 2024

sysopenci commented Mar 21, 2024

sysopenci commented Mar 21, 2024

sysopenci commented Mar 21, 2024

sysopenci commented Mar 22, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 25, 2024

sysopenci commented Mar 26, 2024

sysopenci commented Mar 26, 2024

sysopenci commented Mar 26, 2024

sysopenci commented Mar 26, 2024

xianju6x Mar 21, 2024 •

edited

Loading