Smr0 zhucx #53
Open
Smr0 zhucx #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is almost the same as the one in the ui, but without the UI elements. It would be nice to share code between them, but I'm not sure how to do that yet.
This status is given by the auto-picker when it cannot successfully auto-pick
There's an overflow here if index_size = 4. Caught when bringing up Valhall, not sure why this was never caught before. Yikes. Fixes: 7a6a5f3 ("panfrost: Handle explicit primitive restart") Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15461> (cherry picked from commit 6d51c1b)
Waste of time, and possibly invalid too. Signed-off-by: Alyssa Rosenzweig <[email protected]> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15461> (cherry picked from commit 666b714)
Fixes: a8e53a7 ("spirv: Add generic pointer support") Reviewed-by: Karol Herbst <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15470> (cherry picked from commit 7030d14)
These were, unfortunately, backwards. The source is the texture. The destination is the render target. Fixes: d8cb762 ("iris: Fix MOCS for buffer copies") Reviewed-by: Francisco Jerez <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15473> (cherry picked from commit 4de13d5)
…ith bitsize=1 the specification stipulates that this is a bool value, so don't load it as an int or else nir_validate explodes Fixes: f17b41a ("nir: add lowering pass for helperInvocationEXT()") Reviewed-by: Danylo Piliaiev <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15402> (cherry picked from commit cdcfcb7)
Both are identified as GFX1036 for simplicity. Reviewed-by: Yifan Zhang <[email protected]> Tested-by: Yifan Zhang <[email protected]> (cherry picked from commit f8cf5ea) Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15493>
This attempts to apply each commit, one-by-one, and then pushes it to gitlab for CI results, then if the CI succeeds it considers the commit a success, otherwise it reverts it and continues.
`PointerType::getElementType()` was deprected and is gone now [0]. The *temporary* workaround is using `Type::getPointerElementType()`, longterm this needs to use [1]. This commit fixes an FTBFS. [0] <llvm/llvm-project@d593cf7> [1] <https://llvm.org/docs/OpaquePointers.html> Closes: #6042 Cc: mesa-stable Signed-off-by: Kai Wasserbäch <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15091> (cherry picked from commit 948ad5a)
this can't be determined from pipe_shader_state::stream_output, as this only contains xfb info, which is not the same as the vertex stream info, and may break primitives generated queries cc: mesa-stable Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15506> (cherry picked from commit 32f117f)
With LLVM 15 the include of llvm/IR/Constants.h is required for ConstantInt. This commit fixes an FTBFS. Cc: mesa-stable Signed-off-by: Kai Wasserbäch <[email protected]> Reviewed-by: Dave Airlie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15232> (cherry picked from commit a5884df)
This is not a valid optimization. Fixes: fb29cef ("nir: add many passes that lower and optimize 16-bit input/outputs and samplers") Signed-off-by: Georg Lehmann <[email protected]> Reviewed-by: Daniel Schürmann <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14895> (cherry picked from commit 798e47b)
Most of the code inside the "!prog->data->spirv" blocks shouldn't be executed for SPIR-V except the part updating the writable mask. See https://gitlab.freedesktop.org/mesa/mesa/-/issues/6184 Cc: mesa-stable Reviewed-by: Alejandro Piñeiro <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15552> (cherry picked from commit 61ee560)
Since this entry point is provided by VK_KHR_acceleration_structure, radv has to implement it even if it doesn't support the indirect build feature. Helps Doom Eternal. Fixes: 82de184 ("radv: Enable VK_KHR_acceleration_structure with RADV_PERFTEST=rt.") Signed-off-by: Georg Lehmann <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15573> (cherry picked from commit b8c8e3d)
Entry points have to be provided even if the features are not supported. Helps Doom Eternal. Fixes: f109526 ("radv: Experimentally enable RT extensions.") Signed-off-by: Georg Lehmann <[email protected]> Reviewed-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15573> (cherry picked from commit 37c0f68)
cc: mesa-stable Reviewed-by: Samuel Pitoiset <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15508> (cherry picked from commit e23f881)
We have to add WFM to pending bits when we are flushing into CP for indirect draw to know when they should apply WFM workaround. Fixes CTS tests: dEQP-VK.draw.renderpass.indirect_draw.*_data_from_compute.indirect_draw_count* Fixes: abf0ae0 ("tu: Properly handle waiting on an earlier pipeline stage") Signed-off-by: Danylo Piliaiev <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15577> (cherry picked from commit 37939e9)
The update_ps_state updates ps_shader->current->ps_color_export_mask, so we could miss statechanges. Cc: mesa-stable Acked-by: Gert Wollny <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14427> (cherry picked from commit e0429d9)
Right now we don't explicitly check it and we expect that the output_semantic_index array is always ordered. Unfortunately, this is not the case since 74c02d9 Fixes corruption in Amnesia: the Dark Descent. cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6179 Signed-off-by: Pavel Ondračka <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15523> (cherry picked from commit f82a0d1)
The two types of instructions get added to the same CF list, but not the same instr list within the CF list. So, if you SSBO fetched your texcoord, the emission of the SSBO fetch would come *after* the texcoord fetch. Avoids regressions when NIR-to-TGSI starts optimizing more. Cc: mesa-stable Reviewed-by: Gert Wollny <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14429> (cherry picked from commit ef151d2)
With the NIR-to-TGSI transition, we had fewer other immediates and would end up dereffing past the end of the literals array. Cc: mesa-stable Reviewed-by: Gert Wollny <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14429> (cherry picked from commit 955883c)
Fixes: 2bc8c61 ("iris: Return a 64B stride for clear color plane") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6398 Signed-off-by: Jordan Justen <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16241> (cherry picked from commit 33456ae)
Fixes: 2bc8c61 ("iris: Return a 64B stride for clear color plane") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6398 Signed-off-by: Jordan Justen <[email protected]> Reviewed-by: Nanley Chery <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16241> (cherry picked from commit 33456ae)
If wsi_configure_native_image() fails, it will call wsi_destroy_image_info() itself, so let's try to not call it again from wsi_wl_swapchain_destroy(). Fixes the CTS tests: dEQP-VK.wsi.wayland.swapchain.simulate_oom.* Fixes: b626a5b ("vulkan/wsi/wayland: Split image creation") Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16257> (cherry picked from commit bf04be1)
We don't want to be throwing exceptions and changing float values later by emitting a signaling binary16 nan. If we don't do this, then when we convert back to f32 in NIR constant expression evaluation, the signaling NaN can end up giving NaN for fmax(NaN, 0.0), instead of 0.0. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5933 Cc: mesa-stable Reviewed-by: Emma Anholt <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16233> (cherry picked from commit 27e33d5)
We need to make sure we also properly sort varyings sharing a single slot otherwise we can end up assigning earlier components to the next slot if we have already processed later components. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6392 Fixes: 1e93b0c ("mesa/st: add support for NIR as possible driver IR") Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16208> (cherry picked from commit 180398f)
cc: mesa-stable Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16278> (cherry picked from commit 4a4adb6)
device->l3_config is only valid on Gfx11+ This only fixes using GPU_TRACE=1 Signed-off-by: Lionel Landwerlin <[email protected]> Fixes: 02a4d62 ("anv: expose a couple of emit helper to build utrace buffer copies") Reviewed-by: Tapani Pälli <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16291> (cherry picked from commit 4efc997)
cc: mesa-stable fixes (zink): spec@ext_transform_feedback@generatemipmap prims_generated Reviewed-by: Emma Anholt <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16278> (cherry picked from commit a36c3f6) Conflicts: src/gallium/drivers/zink/ci/zink-lvp-fails.txt
Signed-off-by: Dylan Baker <[email protected]>
…piling Issues including: 1. static declaration of **** follows non-static declaration for function timespec_get 2. ldd error: undefined symbol for functions major and minor 3. ffs and ffsll redefinition issue 4. ldd error: undefined symbol issue for functions build_id and futex 5. TLS symbol error: cannot load any more object with static TLS 6. Intel "Anvil" Vulkan driver requires the dl_iterate_phdr function 7. called object type 'uint32_t' is not a function or function pointer
Android clang add ANDROID note section, which doesn't satify 20 size. This is a workaround for the issue.
Video playback will not work without this patch. INTERNAL: Add importBuffer & release support After we rebased our allocator & mapper from 2.0 to 4.0, we use allocator 4.0 to allocate buffer, which can't be accessed by mapper 2.0 directly. To use the buffer allocated by allocator 4.0, we need importBuffer before lock, and release after unlock. Tracked-On: OAM-95916 Signed-off-by: Ren Chenglei <[email protected]>
This change is to help add NV12, NV12_Y_TILED_INTEL and P010 formats for Android. TESTS: The following CtsViewTestCases cases could pass android.view.cts.PixelCopyTest#testVideoProducer android.view.cts.SurfaceViewSyncTest#testVideoSurfaceViewCornerCoverage android.view.cts.SurfaceViewSyncTest#testVideoSurfaceViewTranslate android.view.cts.SurfaceViewSyncTest#testVideoSurfaceViewRotated android.view.cts.SurfaceViewSyncTest#testVideoSurfaceViewEdgeCoverage Signed-off-by: Lin Johnson <[email protected]> Signed-off-by: Kevin Strasser <[email protected]> Signed-off-by: Chenglei Ren <[email protected]>
This is to help revert part of 57d416d, which causes CTS dEQP regression. Test: dEQP-VK.memory.external_memory_host.* Signed-off-by: Ren Chenglei <[email protected]>
We should confirm height & width valid before call create_resource, otherwise virglrenderer driver will run into error. Tracked-On: OAM-97927 Signed-off-by: Ren Chenglei <[email protected]>
On Android, there will be garbage when screen rotation during video playback. This is to revert d245d7b Signed-off-by: Chenglei Ren <[email protected]> Tracked-On: OAM-99738
This patch try to fix a deadlock issue when runing android.media.cts.HeifWriterTest#testInputSurface_Grid_Handler In this case, there are two deadlock threads involved, the HeifWriter thread and a drawframe thread. The drawframe thread will try to draw a frame and send it to HeifWriter. By calling st_api_make_currentst() it will pending in surface dequeubuffer() with hold of EGL lock, and will block HeifWriter thread executing, the buffer will be returned after HeifWriter handled, In this case HeifWriter waiting for the EGL lock, and drawframe thread wait for buffer with EGL lock hold, so deadlock produced. In case this is not the first time run of make_current(), allocate buffer can be postponed, and allocate buffer in a context without hold of EGL lock. Tracked-On: OAM-96997 Signed-off-by: Yang, Dong <[email protected]> INTERNEL: allocate buffer if there isn't _ColorReadBuffer allocate buffer if there isn't _ColorReadBuffer Tracked-On: OAM-99287 Signed-off-by: Yang, Dong <[email protected]>
Duplicate DRM file descriptor internally instead of reuse. Tracked-On: OAM-102298 Signed-off-by: Basanagouda Koppad <[email protected]>
Feature virgl disk cache is not workable on Celadon with mesa 22.0.3, which blocks virgl_create_screen for VirtIO-GPU solution. According to commit d6db4d2, virgl disk cache is only for performance improvment, so we disable it as workaround for VirtIO-GPU boot issue. Signed-off-by: Lu Yang A <[email protected]> Tracked-On: OAM-102653
Remove zlib.wrap first. Then using "meson wrap install zlib" to add it back Signed-off-by: Yonggang Luo <[email protected]> Reviewed-by: Jesse Natalie <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19187> Tracked-On: OAM-104422 Signed-off-by: Lu Yang A <[email protected]>
Tracked-On: OAM-105546 Signed-off-by: Kalenahally Madegowda, NandishaX <[email protected]> Signed-off-by: Kothapeta, BikshapathiX <[email protected]>
Previously buffer info getting for YUV format by gralloc4 is not complete for egl image creation. Need calculate extra chroma information from layout info. Tracked-On: Signed-off-by: chenyanxzhu <[email protected]>
Currently only support Gralloc0/Gralloc4. Tracked-On: Signed-off-by: chenyanxzhu <[email protected]>
sysopenci
force-pushed
the
celadon/s/mr0/stable
branch
from
90a5650 to
9dccf10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.