Fix static scan issue: dead code and unused value #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
ceiba1985,
dyang23,
GangSecurity,
gkdeepa,
kwang13,
lchen43,
shyjumon-n and
xihua-chen
drivers/dw3/dw3.c
Outdated
| @@ -647,6 +647,9 @@ UsbdSetupHdlr ( | |||
| DEBUG ((DEBUG_INFO, "USB_REQ_SET_ADDRESS\n")); | |||
| if (CtrlRequest->RequestType == USB_RT_TX_DIR_H_TO_D) { | |||
| Status = UsbdSetAddress ((UINT8)CtrlRequest->Value); | |||
| if (EFI_ERROR (Status)) { | |||
| DEBUG ((DEBUG_INFO, "UsbdSetAddress: EFI_DEVICE_ERROR\n")); | |||
| } | |||
There was a problem hiding this comment.
Prefer to keep the previous code flow since this might just be a warning.
drivers/dw3/dw3.c
Outdated
| @@ -590,6 +590,9 @@ UsbdSetupHdlr ( | |||
| CtrlRequest->Length, | |||
| &(mCtrlIoReq.IoInfo.Length) | |||
| ); | |||
| if (EFI_ERROR (Status)) { | |||
| DEBUG ((DEBUG_INFO, "UsbdGetStringDesc() - EFI_DEVICE_ERROR")); | |||
jiaxuan-guo
force-pushed
the
celadon/u/mr0/master
branch
from
518ade3
to
7095cee
Compare
GangSecurity
approved these changes
Sep 20, 2024
sysopenci
removed request for
ceiba1985,
kwang13,
xihua-chen,
lchen43,
gkdeepa,
shyjumon-n and
dyang23
jiaxuan-guo
changed the title
kwang13
approved these changes
Sep 20, 2024
|
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
added
Engineering Build Successful
1. cmd couldn't be NULL 2. redundant check for EfiResetShutdown Tracked-On: OAM-124684 Signed-off-by: Guo, Jade <[email protected]>
The return values of some functions are ignored. Add DEBUG log while continue the code flow without quit early. Include: UsbdSetAddress UsbdGetStringDesc UsbdGetConfigDesc UsbdGetConfig UsbdSetConfig UsbdGetStatus VirtioRpmbInitialize Tracked-On: OAM-124684 Signed-off-by: Guo, Jade <[email protected]>
|
Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
merged commit ad3d14a
into
projectceladon:celadon/u/mr0/master
22 checks passed
|
Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAM-124684