Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition with vpp #94

Open
wants to merge 4 commits into
base: celadon/u/mr0/master
Choose a base branch
from
Open

Composition with vpp #94

wants to merge 4 commits into from

Conversation

HaihongxLi
Copy link
Contributor

No description provided.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Nov 18, 2024
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@HaihongxLi HaihongxLi force-pushed the vpp branch 2 times, most recently from d374753 to 2e3fde9 Compare November 18, 2024 02:32
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@HaihongxLi
Composition with vpp
1f01441 
Signed-off-by: lihaihong <[email protected]>
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@phreer @HaihongxLi
varenderer: Create VA surface with PRIME_2 API
207792d 
...as PRIME_2 API allows us to set modifier.

Signed-off-by: Weifeng Liu <[email protected]>
phreer
phreer reviewed Dec 26, 2024
View reviewed changes
va/varenderer.cpp
}

bool VARenderer::AllocateCache(uint32_t layer_capacity) {
surface_in_ = (VASurfaceID*)malloc(sizeof(VASurfaceID) * layer_capacity);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use std::vector to manage these resources as we are writing C++ here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

porting from previous, now we need poc and do some test, next will refine

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@HaihongxLi
ATRACE debug pm
2ae8599 
Signed-off-by: lihaihong <[email protected]>
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phreer phreer phreer left review comments

Assignees
No one assigned
Labels
Engineering Build Not Started Engineering Build Not Started Invalid commit message Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaihongxLi @sysopenci @phreer