Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sepolicy for intel evs app #336

Merged
merged 1 commit into from
Aug 27, 2024
Merged

sepolicy for intel evs app #336

merged 1 commit into from
Aug 27, 2024

Conversation

shivasku82
Copy link
Contributor

No description provided.

@sysopenci
Copy link

Expected syntax:
Commit message one-line summary

  Extra paragraphs can be added here.

  Longer description that explains the problem / solution
  or whatever that needs to be said

  It can contain
    multiple lines
    multiple paragraphs
    blank lines
    references

  But each paragraph must be followed by a blank line

  However, you need to keep the 'Tracked-On', 'Change-Id',
  'Signed-off-by', ..., fields in the **lastest** paragraph of
  the commit message.

  Change-Id: I9e58f79c7faf7f0edb9792e8b5322ab161331141
  Tracked-On: https://jira.server.ext/browse/PROJECTA-123
  Signed-off-by: Developer Name <[email protected]>

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Aug 24, 2024
@shivasku82 shivasku82 force-pushed the evs_intel_app_sepolicy branch from d613e5a to 6f6ebf0 Compare August 24, 2024 14:05
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Aug 24, 2024
@shivasku82 shivasku82 force-pushed the evs_intel_app_sepolicy branch from 6f6ebf0 to 3cda9ed Compare August 25, 2024 15:54
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@shivasku82 shivasku82 force-pushed the evs_intel_app_sepolicy branch from 3cda9ed to 06061ce Compare August 25, 2024 17:50
@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Failed labels Aug 25, 2024
@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

neofang7
neofang7 approved these changes Aug 26, 2024
View reviewed changes
Copy link

@neofang7 neofang7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

balajim001
balajim001 approved these changes Aug 26, 2024
View reviewed changes
Copy link

@balajim001 balajim001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeevakaPrabu
JeevakaPrabu suggested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@JeevakaPrabu JeevakaPrabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove changes from line 34 to 51 and add only needed policies
  • Add tests done to commit message and also in commit message add a Note: EVS intel app is customized version of default evs app to support virtio and ....

@shivasku82
add sepolicy to run intel evs app
226e2bd 
sepolicy is needed for running intel evs app

intel evs app is customized version of default evs app to
support camera virtio.

Tests Done : Tested EVS app for surround view and different gear
conditions

Tracked-On: OAM-123219
Signed-off-by: shivasku82 <[email protected]>
@shivasku82 shivasku82 force-pushed the evs_intel_app_sepolicy branch from 06061ce to 226e2bd Compare August 26, 2024 16:29
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Aug 26, 2024
@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

ceiba1985
ceiba1985 reviewed Aug 27, 2024
View reviewed changes
car/file_contexts
@@ -3,3 +3,7 @@

/vendor/bin/hw/android.hardware.broadcastradio@intel-service u:object_r:hal_broadcastradio_default_exec:s0
/vendor/bin/hw/[email protected] u:object_r:hal_audiocontrol_default_exec:s0

/system/bin/evs_intel_app u:object_r:evs_intel_app_exec:s0
/system/bin/evs_app_support_lib u:object_r:evs_intel_app_exec:s0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not proper to put Intel's binary to system partition. It will be lost after flashing the GSI image.

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 353320f into projectceladon:celadon/u/mr0/master Aug 27, 2024
18 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceiba1985 ceiba1985 ceiba1985 left review comments

@balajim001 balajim001 balajim001 approved these changes

@JeevakaPrabu JeevakaPrabu JeevakaPrabu approved these changes

@neofang7 neofang7 neofang7 approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shivasku82 @sysopenci @ceiba1985 @neofang7 @JeevakaPrabu @balajim001