Upgrade caluma #12
Closed
Upgrade caluma #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongpu
reviewed
Sep 8, 2023
| @@ -1,8 +1,8 @@ | |||
| apiVersion: v1 | |||
| name: caluma | |||
| description: A collaborative form editing service | |||
| version: 0.10.2 | |||
| appVersion: 7.7.0 | |||
| version: 0.10.3 | |||
There was a problem hiding this comment.
When you upgrade the appVersion over multiple major releases, then you should definitely also increase the minor version of the chart.
Suggested change
| version: 0.10.3 | |
| version: 0.11.0 |
| @@ -2,9 +2,9 @@ | |||
| {{- $fullName := include "caluma.fullname" . -}} | |||
| {{- $svcPort := .Values.service.port -}} | |||
| {{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}} | |||
| apiVersion: networking.k8s.io/v1beta1 | |||
| apiVersion: networking.k8s.io/v1 | |||
There was a problem hiding this comment.
Nowadays Kubernetes releases which don't support networking.k8s.io/v1 should be very rare, so I would suggest to remove the whole if/else section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.