Move set and health packages here to avoid Felix/Typha duplication #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lib/health/health.go
Outdated
| log.Debug("GET /readiness") | ||
| status := STATUS_BAD | ||
| if state.Ready() { | ||
| log.Debug("Felix is ready") |
There was a problem hiding this comment.
We shouldn't have Felix specific logging in libcalico.
|
I need to think about whether or not this belongs in libcalico-go some more. It's nice to make things common, but also libcalico shouldn't be the go-to place to put any lines of code that are shared across >1 Calico components. |
|
For the record, we've agreed that libcalico-go is a reasonable home for common packages such as these. I've just updated this PR so as to have the latest health package code, as reviewed and revised at projectcalico/felix#1489. Next steps:
|
caseydavenport
approved these changes
Jul 14, 2017
song-jiang
pushed a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 19, 2021
…ico#462) Co-authored-by: Alina Militaru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'set' and 'health' are library packages used by both Felix and Typha. By moving them here we can eliminate duplicate code in the Felix and Typha repos - and anyway they probably should be here as this is lib calico-go.