Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-HPC Calico for Windows issues #9016

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix non-HPC Calico for Windows issues #9016

merged 1 commit into from
Jul 17, 2024

Commits on Jul 16, 2024

  1. Fix non-HPC Calico for Windows issues 

    The windows upgrade code was cleaned up in projectcalico#7857, but there were leftover calls to it in node-service.ps1, leading to errors:

flag provided but not defined: -should-install-windows-upgrade

In addition to that, the token refresher, when run in a non-HPC scenario, would fail (on top of being unnecessary in non-HPC since that already requires the kubeconfig to be copied into the windows host):

2024-07-16 20:38:31.133 [FATAL][5064] cni-config-monitor/token_watch.go 59: Failed to read service account namespace file error=open /var/run/secrets/kubernetes.io/serviceaccount/namespace: The system cannot find the path specified.

These were masked by the fact that logs are complex to get in non-HPC windows (requires RDP access into the host machine, so e2e failures retrieve nothing), and kubectl get nodes would show the windows nodes as 'Ready' even though these errors were occurring.
    @coutinhop
    coutinhop committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4821bf2 View commit details
    Browse the repository at this point in the history