Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA support for Windows hostprocess containers #7857

Merged
merged 16 commits into from
Sep 15, 2023

Commits on Jul 27, 2023

  1. [WIP] Add GA support for Windows hostprocess

    Build on the changes from projectcalico#7260:
    - Add a Windows cni-plugin hostprocess image, which will install the cni
      binaries and config on the host.
    - Add a Windows node hostprocess image, which no longer needs to match
      the hosts' Windows version (e.g. only 1809 needs to be used and is
      supported on 2022).
    coutinhop committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    fe5a471 View commit details
    Browse the repository at this point in the history
  2. Use windows-host-process-containers-base-image instead of nanoserver as

    base for windows HPC images.
    
    Add uninstall-calico powershell script to be run in initContainer, which
    will clean up non-HPC Calico installations from the host before starting
    Calico Windows HPC.
    
    Fix bug in confd-service.ps1
    coutinhop committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f9da7f5 View commit details
    Browse the repository at this point in the history
  3. Remove getHostPath() function as it is no longer necessary for Windows

    HPC when using containerd v1.7+
    coutinhop committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1a6e1be View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d28c912 View commit details
    Browse the repository at this point in the history
  5. Add quotes to windows cni plugin template so that it's valid JSON even

    before substitution (this helps with operator testing).
    coutinhop committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    58c1695 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e202970 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. image, build and file path changes to make windows HPC compatible wit…

    …h containerd
    
    v1.6+ (instead of requiring v1.7+).
    coutinhop committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d177bbd View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Make HPC work with containerd v1.6 (by referring to all paths prefixe…

    …d with '$env:CONTAINER_SANDBOX_MOUNT_POINT').
    
    Fix logic regarding CNI paths in uninstall-calico-hpc.ps1.
    coutinhop committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c81279d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Add support for multiple kubernetes service CIDRs

    Fix bug in GetHostPath()
    coutinhop committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    bac65a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    678854e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Add InHostProcessContainer(), GetInClusterConfig(), BuildConfigFromFl…

    …ags()
    
    to winutils.go and use them instead of upstream's InClusterConfig(),
    BuildConfigFromFlags() in order to get Windows HPC to work with containerd v1.6.
    (tests intentionally left untouched in order to try to catch
    discrepancies in behavior from upstream if/when they happen).
    
    Fix PATH in Windows dockerfiles.
    coutinhop committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    aad494b View commit details
    Browse the repository at this point in the history
  2. Remove winupgrade code

    coutinhop committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a7021e6 View commit details
    Browse the repository at this point in the history
  3. 'make fix' on confd

    coutinhop committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f28243a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Fix KUBECONFIG env var bleeding from host to containers on windows.

    Use winutils.GetHostPath() on file paths in felix param_types.go.
    Add resolving of $env:CONTAINER_SANDBOX_MOUNT_POINT to winutils.GetHostPath().
    coutinhop committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1401e4a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    b67cd5a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Address review comments:

    - clarify HPC env var comments
    - add logging when skipping chmod on windows
    - fix kubeconfigPath prefix issue
    coutinhop committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e90395c View commit details
    Browse the repository at this point in the history