-
Notifications
You must be signed in to change notification settings - Fork 1.4k
When CNI ADD success, return all interfaces #10382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks!
/sem-approve |
/sem-approve |
I passed the test locally by executing |
903b3c4
to
795ffcd
Compare
I think I know the reason. The key issue is cni version. The comparison is as follows:
0.2.0
The default version is 0.3.1, and the result is normal, but CI uses 0.2.0, which does not support interfaces. |
I added version checking in the test cases, the spec for versions lower than 0.3.0 will be skipped. |
@caseydavenport Need to re-trigger CI, thanks. |
/sem-approve |
Looks like you need to run |
5deaa5e
to
11f6017
Compare
Signed-off-by: DrAuYueng <[email protected]>
11f6017
to
7609a70
Compare
I run |
/sem-approve |
Description
When CNI ADD success, return all interfaces created by the attachment, including any host-level interfaces.
Related references:https://github.com/containernetworking/cni/blob/main/SPEC.md#add-success
Resolves #10351.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.