regression tests for existing kinds of bad params currently handled okay #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not include #300 because I exceeded my time budget trying to resolve it. |
But in past versions of bl_range_limit i know from my own app resulted in uncaught exception 500s
One test applying to formerly without tests #294. In process, I realize that the values displayed in the "constraint" aren't clamped, so that'd be an area of improvement -- but I'm not too worried about it, I don't personally have a use case for it. The main thing is ensuring this bad data doesn't result in an uncaught exception, which this regression test now does.
|
Aha, one example is actually NOT handled okay in BL7, although is in BL8. Trying to figure out what's up. |
This branch correction is not necessary in BL 8, not sure why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But in past versions of bl_range_limit i know from my own app resulted in uncaught exception 500s
and: Test that out of bounds ranges do not result in error
One test applying to formerly without tests #294.
In process, I realize that the values displayed in the "constraint" aren't clamped, so that'd be an area of improvement -- but I'm not too worried about it, I don't personally have a use case for it. The main thing is ensuring this bad data doesn't result in an uncaught exception, which this regression test now does.