Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue primary testing with Blacklight 7 #1180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Continue primary testing with Blacklight 7 #1180

wants to merge 1 commit into from

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Oct 17, 2022

No description provided.

@jcoyne
Copy link
Member

jcoyne commented Oct 17, 2022

It looks to me like this suffers from

Arclight Importmap asset generation
      append  config/importmap.rb
The file /home/runner/work/arclight/arclight/.internal_test_app/app/javascript/application.js does not appear to exist

https://github.com/projectblacklight/arclight/actions/runs/3267826382/jobs/5373500409#step:5:1143

which was fixed by projectblacklight/blacklight#2834

@cbeer
Copy link
Member Author

cbeer commented Oct 18, 2022

It doesn't look like Blacklight 7.31 fixed this. Any ideas, or should we revert the 8.x change until we can fix this?

@jcoyne
Copy link
Member

jcoyne commented Oct 18, 2022

@cbeer no, I don't think we should revert. The problem now is:

 Arclight Importmap asset generation
      append  config/importmap.rb
File unchanged! The supplied flag value not found!  app/javascript/application.js

and the in-progress fix is in: projectblacklight/blacklight#2838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants