This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Dockerfile: Update version and add verification #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Milner <[email protected]>
miabbott
reviewed
Nov 15, 2017
Dockerfile
Outdated
| MAINTAINER Jonathan Lebon <[email protected]> | ||
|
|
||
| # NB: we install libyaml-devel so that we can use | ||
| # CSafeLoader in PyYAML (see related comment in the parser) | ||
|
|
||
| RUN dnf install -y \ | ||
| RUN dnf install --setopt=tsflags=nodocs -y \ |
There was a problem hiding this comment.
I don't think this is necessary because those options are enabled by default in the fedora:27 image:
$ sudo docker run -it registry.fedoraproject.org/fedora:27 cat /etc/dnf/dnf.conf
[main]
gpgcheck=1
installonly_limit=3
clean_requirements_on_remove=True
tsflags=nodocs
|
This is probably fine and should probably work, but because it's the image that is run by all PAPR jobs, I need to test it out first. The way I do this currently is push to the |
|
@jlebon best to be safe before merging 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.