This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
Do not assume that util.skopeo_copy can't fail #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
reviewed
Dec 11, 2017
Atomic/run.py
Outdated
| db.pull_image(self.image, remote_image_obj) | ||
| err = db.pull_image(self.image, remote_image_obj) | ||
| if err: | ||
| raise ValueError("Unable to pull image {}"..format(self.image)) |
There was a problem hiding this comment.
there is one extra '.' here
There was a problem hiding this comment.
doesn't it fail immediately once pull_image raises CalledProcessError?
There was a problem hiding this comment.
Nice catch, I will fix. And no, it doesn't seems to raise anything. I sent the PR first to see the tests running, but I didn't had time to test or validate it (as I reinstalled my system with enough disk).
giuseppe
suggested changes
Dec 11, 2017
| @@ -343,9 +343,8 @@ def pull_image(self, image, remote_image_obj, **kwargs): | |||
| trust = Trust() | |||
| trust.discover_sigstore(fq_name) | |||
| util.write_out("Pulling {} ...".format(fq_name)) | |||
| util.skopeo_copy("docker://{}".format(fq_name), image, debug=debug, insecure=insecure, | |||
| return util.skopeo_copy("docker://{}".format(fq_name), image, debug=debug, insecure=insecure, | |||
There was a problem hiding this comment.
doesn't it raise a CalledProcessError exception when skopeo_copy fails?
Atomic/run.py
Outdated
| db.pull_image(self.image, remote_image_obj) | ||
| err = db.pull_image(self.image, remote_image_obj) | ||
| if err: | ||
| raise ValueError("Unable to pull image {}"..format(self.image)) |
There was a problem hiding this comment.
doesn't it fail immediately once pull_image raises CalledProcessError?
If the disk is full (projectatomic#1146), atomic will continue and show errors later, which is puzzling and hard to debug.
mscherer
force-pushed
the
warn_when_disk_full
branch
from
d560ce5 to
fd19508
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the disk is full, atomic will continue and show errors later, which is puzzling and hard to debug.
Related Bugzillas
Related Issue Numbers
Pull Request Checklist:
If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.