Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

Dockertar sha256 helper enhancements #1117

Closed
wants to merge 3 commits into from
Closed

Dockertar sha256 helper enhancements #1117

wants to merge 3 commits into from

Conversation

ashcrow
Copy link
Contributor

@ashcrow ashcrow commented Oct 13, 2017

Description

  • Error when the wrong number of arguments are provided
  • Ensure closing of all open items using defer.

@ashcrow
dockertar-sha256-helper: Error without arg
3c897b9 
Provide a human understandable error when an argument is not provided.

Signed-off-by: Steve Milner <[email protected]>
@ashcrow
dockertar-sha256-helper: Defer Close
3d1995b 
Defer Close calls to ensure closing at the end of the function.

Signed-off-by: Steve Milner <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Oct 13, 2017

LGTM

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 13, 2017

Hrm, deferring the close seems to change the result. Looking at it...

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 13, 2017

As it turns out the sha instance must be explicitly closed before the sum executes else the results are different.

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 13, 2017

bot retest this please

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 13, 2017 

Running test_storage.sh....                     FAIL

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 16, 2017

CentOS error is unrelated. Will ask for one more retest.

wipefs: error: /dev/vdb: probing initialization failed: Device or resource busy

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 16, 2017

bot, retest this please

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 16, 2017 •
edited
Loading

CentOS failed in a different way

+ dnf install -y git make python2-pylint python3-pylint python3-slip-dbus python-gobject-base python-dbus pylint python-slip-dbus python-docker-py python2-dateutil PyYAML rpm-python 'dnf-command(builddep)'
Error: Failed to synchronize cache for repo 'updates'
+ '[' -z ']'
+ make pylint-check
/code/.papr.sh: line 76: make: command not found

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 16, 2017

bot, retest this please

@ashcrow
Copy link
Contributor Author

ashcrow commented Oct 16, 2017

@jlebon FYI 🔼

@giuseppe
Copy link
Collaborator

giuseppe commented Oct 16, 2017 •
edited
Loading

@rh-atomic-bot r+ d06444e

@rh-atomic-bot
Copy link

🙀 3d1995b is not a valid commit SHA. Please try again with d06444e.

@rh-atomic-bot
Copy link

⌛ Testing commit d06444e with merge 6dddc4c...

rh-atomic-bot pushed a commit that referenced this pull request Oct 16, 2017
@ashcrow @rh-atomic-bot
dockertar-sha256-helper: Defer Close
6dddc4c 
Defer Close calls to ensure closing at the end of the function.

Signed-off-by: Steve Milner <[email protected]>

Closes: #1117
Approved by: giuseppe
@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
Approved by: giuseppe
Pushing 6dddc4c to master...

@jlebon
Copy link
Contributor

jlebon commented Oct 16, 2017

Error: Failed to synchronize cache for repo 'updates'

That's just flaky infra. :(
See also projectatomic/papr#53.

eyusupov pushed a commit to eyusupov/atomic that referenced this pull request Mar 10, 2018
@ashcrow @eyusupov
dockertar-sha256-helper: Error without arg
92d4829 
Provide a human understandable error when an argument is not provided.

Signed-off-by: Steve Milner <[email protected]>

Closes: projectatomic#1117
Approved by: giuseppe
eyusupov pushed a commit to eyusupov/atomic that referenced this pull request Mar 10, 2018
@ashcrow @eyusupov
dockertar-sha256-helper: Defer Close
7de06a1 
Defer Close calls to ensure closing at the end of the function.

Signed-off-by: Steve Milner <[email protected]>

Closes: projectatomic#1117
Approved by: giuseppe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashcrow @rhatdan @giuseppe @rh-atomic-bot @jlebon