Allow passing PCM data as slices instead of Vec #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatGPT recommended using slices because we can avoid extra allocations and ownership transfer when adding PCM data.
• Changed the samples parameter from Vec to &[f32] in both the public and internal methods. This allows you to pass a slice directly without allocating a new Vec.
• Since slices are borrowed references, there’s no ownership transfer, which is more efficient.
• Slices can still provide a raw pointer using .as_ptr(), so the FFI call remains unchanged.
Might be a breaking change though, if we care